Source code links #679
Merged
Source code links #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtheclark
force-pushed
the
css-snippet-links
branch
2 times, most recently
from
2011b9f
to
d005621
Compare
|
This is pretty much working now. Here's where I put a Source link (under the selectors):
Any other suggestions? |
|
@samanpwbb for review. |
davidtheclark
force-pushed
the
css-snippet-links
branch
from
d005621
to
6e69cb5
Compare
|
@davidtheclark this is great! I adjusted the design a little:
let me know if that seems okay to you |
|
@samanpwbb 🆒 let's give this a try |
Closes #626. Layout scales and color variants are now built to files in src/ with a warning comment at the top. src/ files are read by documentation-css, instead of the built file.
davidtheclark
force-pushed
the
css-snippet-links
branch
from
428c65c
to
0b5e993
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #660.
This just gets harder the deeper I get. The current blocker is that generated files (e.g.
layout-scales.css) reference documentation sections that are not in the same file — and that breaksdocumentation-css. Have no idea how to get around this.