Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS, generally #17

Closed
davidtheclark opened this issue Jun 9, 2017 · 1 comment
Closed

CSS, generally #17

davidtheclark opened this issue Jun 9, 2017 · 1 comment
Labels

Comments

@davidtheclark
Copy link
Contributor

Besides inlining critical CSS in the static build (#4), there are other considerations:

  • Authors need to be able to designate page-specific CSS, as text and as URLs.
  • Authors need to be able to designate site-wide CSS, as text and as URLs.
  • While the URLs above code be external (e.g. the Assembly CDN URL), I think we'll ultimately pull it down, bundle it up, and serve it locally. This way we can exercise some more control for optimizations, like delaying the loading of the site-wide CSS file until rendering is complete (since it's unnecessary before you change pages, since all CSS for the page will be inlined). This means we need to have users specify CSS as URLs, not as <link> elements to add to the head.
  • While we could include some CSS processor defaults (maybe just Autoprefixer), it'd also be nice to allow users to specify PostCSS plugins to add to pipeline.
@davidtheclark
Copy link
Contributor Author

Trick about external CSS: all of the asset references inside it (images, fonts) are relative to its actual URL. Will have to transform those in case they are relative.

davidtheclark pushed a commit that referenced this issue Jun 9, 2017
Closes #17.
Closes #4.
davidtheclark added a commit that referenced this issue Jun 9, 2017
Closes #17.
Closes #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant