Bbox paging #155
Merged
Bbox paging #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| var maxPages = 10; | ||
| var page = 0; | ||
| var combinedFeatures = []; |
There was a problem hiding this comment.
Is it worth limiting based on feature count or data size, whichever you hit first?
There was a problem hiding this comment.
We dont limit on size with the list queries right now (because the features could be on s3) but we limit to 1 page or 100 features. I dont think we need this right now, and in the future this will be limited by dynamo if we keep all the features in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR feels like a step back in a way, but this enables a simple way of handing paging on bbox queries for small datasets. The next steps to make this better bbox query better involve schema changes, so lets start here for now.
This just does a list query for all features with a queryfilter. Query filters in dynamo are applied after the data is fetch on dynamo, but before it is returned to client. So some pages will be empty, some pages will have few items, but this does allow for us to page through a bbox query using feature id.
cc @willwhite @rclark