This repository has been archived by the owner on Oct 30, 2021. It is now read-only.
Word boundary scan #138
Merged
Word boundary scan #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
apendleton
approved these changes
Dec 6, 2018
There was a problem hiding this comment.
🌮 looks good. Noting that most of this was already reviewed in #137, and my comments on that PR have been addressed here in the rebased version. Happy about the constants for boundary matching -- we'll probably want to produce the same values as output from mapbox/fuzzy-phrase#56 that we expect as input here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get carmen-cache to respect tokenized words & not attempt to complete them for you. See https://github.com/mapbox/carmen/pull/795
This PR is a replacement for #137 after rebasing on the 0.22.0 refactor.
Current status; functional. Outstanding tasks;