Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Fix documentation of text-line-spacing #452

Closed
sommerluk opened this issue Nov 20, 2016 · 4 comments
Closed

Fix documentation of text-line-spacing #452

sommerluk opened this issue Nov 20, 2016 · 4 comments
Milestone

Comments

@sommerluk
Copy link

At https://github.com/mapbox/carto/blob/master/docs/latest.md#text-line-spacing-unsigned it is declared that text-line-spacing is an unsigned value. So negative values are declared is illegal (and I suppose it means also that only integer values are allowed, right?).

However line-spacing at Mapnik at https://github.com/mapnik/mapnik/wiki/TextSymbolizer is declared as double.

I’ve tested negative floating point values like “-5.9” in the CartoCSS-Mapnik-combination, and indeed it decreases the baseline-to-baseline distance of the lines.

I do not know how CartoCSS works internally, but I suppose that it forwards simply the value of “text-line-spacing” to the Mapnik counterpart “line-spacing”. So I guess the documentation of CartoCSS should be fixed to allow also negative floating point values for text-line-spacing.

@nebulon42
Copy link
Collaborator

Thanks for noticing! I'm pretty sure there is no specific logic for this, so it is like you say: The value is directly given to Mapnik. All the details come from mapnik-reference, for example see here: https://github.com/mapnik/mapnik-reference/blob/gh-pages/3.0.6/reference.json#L2125

Could you please report this to mapnik-reference?

@sommerluk
Copy link
Author

Could you please report this to mapnik-reference?

mapnik/mapnik-reference#124

@nebulon42
Copy link
Collaborator

Re-opening until resolved upstream.

@nebulon42 nebulon42 reopened this Dec 11, 2016
@nebulon42
Copy link
Collaborator

PR: mapnik/mapnik-reference#130

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants