Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

OSM Bright theme rendering black roads #471

Closed
StarFi55ure opened this issue Apr 26, 2017 · 3 comments
Closed

OSM Bright theme rendering black roads #471

StarFi55ure opened this issue Apr 26, 2017 · 3 comments

Comments

@StarFi55ure
Copy link

I have a problem with the mapbox osm-bright theme when rendered with a carto generated mapnik xml file. In the bridges layer, the bridges are rendered black instead of their normal colors.

Ive attached a picture below, in which I deactivated the roads layers to show just the bridges. When I generate a mapnik xml directly from TileOven, the rendering is fine.

Carto: v0.17.2
NodeJS: 4.8.2
Mapnik version: 3.0.13
Command used: carto project.mml > project.xml

Carto XML Rendering

image

TileOven XML Rendering

image

@nebulon42
Copy link
Collaborator

nebulon42 commented Apr 30, 2017

Thanks for the report, I'll investigate.
Affects 0.17.2 and master. Does not affect 0.16.3.

@nebulon42
Copy link
Collaborator

nebulon42 commented May 1, 2017

Git bisect tells me that 9be4e86 introduced this behaviour.

Problem is that I didn't expect parseFloat being that dump having that feature. OSM Bright uses filters of the form [render='1_outline'] which parseFloat treats as number because they begin with one.

nebulon42 added a commit that referenced this issue May 1, 2017
… for strings that begin with a number, but shouldn't be treated as one
@nebulon42
Copy link
Collaborator

Fixed in v0.17.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants