Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the algorithm from generating self-intersecting polygons #1

Closed
mourner opened this issue Feb 10, 2016 · 5 comments
Closed

Prevent the algorithm from generating self-intersecting polygons #1

mourner opened this issue Feb 10, 2016 · 5 comments
Labels

Comments

@mourner
Copy link
Member

mourner commented Feb 10, 2016

In some cases, the algorithm generates self-intersections. We should fix this and guarantee that the resulting concave hull is a simple polygon.

@mourner mourner added the bug label Feb 10, 2016
mourner added a commit that referenced this issue Feb 10, 2016
@mourner
Copy link
Member Author

mourner commented Feb 10, 2016

Fixed partially but not quite, full fix in progress — will have to index concave hull segments with rbush too, and check intersections against all segments.

@rhwang201
Copy link

@mourner any updates on a full fix for self-intersections?

@mourner
Copy link
Member Author

mourner commented May 31, 2017

@rhwang201 did a full fix in b2f27df. Are you experiencing a failing case?

@rhwang201
Copy link

rhwang201 commented Jun 1, 2017

@mourner seeing self-intersections in a project that uses concaveman to generate polygons. https://github.com/urbica/galton uses https://github.com/stepankuzmin/node-isochrone, which uses v1.1.1 of concaveman, which includes that commit.

Can reproduce by starting a local Galton server following the "Example" section in the README, and then examining the output of curl http://localhost:4000 --get --data 'lng=-122.139935&lat=37.422744&intervals=15&bufferSize=50&cellWidth=0.5&concavity=3&resolution=20000

@mourner
Copy link
Member Author

mourner commented Jun 1, 2017

Can you set up a self-contained test case (just concaveman, without any additional libraries and servers)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants