Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Division by zero in findHoleBridge #48

Closed
springmeyer opened this issue Jan 13, 2017 · 0 comments · Fixed by #50
Closed

Division by zero in findHoleBridge #48

springmeyer opened this issue Jan 13, 2017 · 0 comments · Fixed by #50
Assignees
@mourner

Comments

@springmeyer
Copy link
Contributor

springmeyer commented Jan 13, 2017 •
edited

Division by zero in C++ may cause an unrecoverable crash and needs to be avoided. The -fsanitize=undefined in clang++ 3.9.1 spotted a case where division by zero happens in findHoleBridge during the mbgl unit tests because p->next->y - p->y == 0:

earcut.hpp/include/mapbox/earcut.hpp

Line 468 in 888acfc

double x = p->x + (hy - p->y) * (p->next->x - p->x) / (p->next->y - p->y);

/cc @mourner

refs mapbox/mapbox-gl-native#5379
@springmeyer springmeyer mentioned this issue Jan 13, 2017
Closed
@mourner mourner self-assigned this Jan 13, 2017
mrgreywater added a commit to mrgreywater/earcut.hpp that referenced this issue Jan 13, 2017
@mrgreywater
fix division by zero mapbox#48
c01f605
@mrgreywater mrgreywater mentioned this issue Jan 13, 2017
Merged
mrgreywater added a commit to mrgreywater/earcut.hpp that referenced this issue Jan 13, 2017
@mrgreywater
fix division by zero mapbox#48
6cb59a5
mrgreywater added a commit to mrgreywater/earcut.hpp that referenced this issue Jan 13, 2017
@mrgreywater
fix division by zero mapbox#48
caa731a
mrgreywater added a commit to mrgreywater/earcut.hpp that referenced this issue Jan 13, 2017
@mrgreywater
fix division by zero mapbox#48
3932a1e
mrgreywater added a commit to mrgreywater/earcut.hpp that referenced this issue Jan 13, 2017
@mrgreywater
fix division by zero mapbox#48
4f4db25
mrgreywater added a commit to mrgreywater/earcut.hpp that referenced this issue Jan 13, 2017
@mrgreywater
fix division by zero mapbox#48
1ffd8ef
mourner pushed a commit that referenced this issue Jan 13, 2017
@mrgreywater @mourner
fix division by zero #48 (#50)
b6d8d37
@springmeyer springmeyer mentioned this issue Jan 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mourner mourner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix division by zero #48 mrgreywater/earcut.hpp
2 participants
@springmeyer @mourner