Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messageTimeout default to max value #145

Closed
rclark opened this issue Apr 12, 2017 · 1 comment
Closed

messageTimeout default to max value #145

rclark opened this issue Apr 12, 2017 · 1 comment

Comments

@rclark
Copy link
Contributor

rclark commented Apr 12, 2017

messageTimeout is an important, but often overlooked parameter. Currently, its default setting is an arbitrarily chosen value (10 minutes). If jobs take longer to process than 10 minutes, and the caller hasn't learned about messageTimeout yet, they get pretty confusing results where jobs are processed more than once.

Instead of this arbitrary 10 min timeout, the default value should be the maximum possible from SQS.

@brendanmcfarland
Copy link
Contributor

In watchbot 4 messageTimeout is now defaulted to 3 minutes. message.heartbeat will keep refreshing the visibility timeout, and maxJobDuration is available as a parameter for limiting how long a message will be processed before the child_process is killed and the message is retried. see #203 & #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants