maxJobDuration, timeout heartbeat for watchbot 4 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jakepruitt i'm feeling pretty good about where maxJobDuration and message.heartbeat are at now, and tested them quite a bit on a watchbot stack. A review would be helpful when you get a chance, - primarily focused on the changes in worker and heartbeat. I'm punting on scaling improvements on the minsize 0->1 message case in this PR, and had a bit of a bear fight with jest. For some reason going past v22.1 is resulting in jest not finding any tests and exit'n 1. |
brendanmcfarland
changed the title
This was referenced Jul 3, 2018
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on the message heartbeat in a fresh branch