-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes deadletter related tickets #220
Conversation
bc293ff
to
1b6919a
Compare
Just a note on file structure: I think rather than going with the watchbot v3 pattern of
We should instead make Lines 9 to 12 in 09e69ee
With Then, within |
mappings/ecr-region.json
Outdated
}, | ||
"us-east-2": { | ||
"Region": "us-east-1" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to add the ECR mappings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per my understanding ECR is available in all regions but ecs-conex images are stored in few regions, would it be needed to define the mapping while creating a new ecs-watchbot service in a region as to where ecs-conex is writing images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tapasweni-pathak ooo good catch, I didn't check line 339 of lib/template before.
f264dd0
to
db09a83
Compare
c865757
to
8030079
Compare
Alright, gave a shot at refactoring some of this, but there's definitely more room for improvement if you want to pick any of this up @arunasank! |
Alright, I think all of the tests are passing now. This still needs real-life tests against dead letters with messages in them before we can merge. |
👋 @jakepruitt Is there a reason you renamed the |
Things related to deadletter, cli.
Closes #141.
Closes #159.
Closes #192.
Closes #193.
cc @mapbox/platform-engine-room.