Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a metrics dashboard #222

Merged
merged 13 commits into from
Jun 19, 2018
Merged

Set up a metrics dashboard #222

merged 13 commits into from
Jun 19, 2018

Conversation

arunasank
Copy link
Contributor

@arunasank arunasank commented Jun 18, 2018

Fixes #216

cc/ @mapbox/platform-engine-room

TODO

  • Test this out, to see what the dashboard looks like

@arunasank
Copy link
Contributor Author

What the dashboard looks like:

screen_shot_2018-06-18_at_9_31_27_pm

@arunasank arunasank changed the title [wip] Set up a metrics dashboard Set up a metrics dashboard Jun 18, 2018
Copy link

@jakepruitt jakepruitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few thoughts on the titles, panels that we could potentially drop, and one Statistic that needs to be changed. Otherwise this looks great and is super exciting!

lib/dashboard.js Outdated
properties: {
view: 'timeSeries',
stacked: false,
title: 'WatchbotQueue: ApproximateNumberOfMessagesNotVisible, ApproximateNumberOfMessagesVisible',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: could we make this name shorter? I don't think the full title would fit in the dashboard UI. Could we maybe change it to Visible and NotVisible Messages?

lib/dashboard.js Outdated
stacked: false,
title: 'WatchbotQueue: NumberOfMessagesDeleted',
metrics: [
['AWS/SQS', 'NumberOfMessagesDeleted', 'QueueName', '${AWS::StackName}-WatchbotQueue', { period: 60 }]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a place to specify the Statistic to assess for this metric? I believe we want the Sum here, and the screenshot you made was using the Average.

lib/dashboard.js Outdated
metrics: [
['Mapbox/ecs-cluster', 'RunningCapacity', 'ClusterName', '${Cluster}', 'ServiceName', '${WatchbotService}', { period: 60 }],
['.', 'DesiredCapacity', '.', '.', '.', '.', { period: 60 }],
['AWS/SQS', 'NumberOfMessagesDeleted', 'QueueName', '${AWS::StackName}-WatchbotQueue', { period: 60 }]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, we'll want this metric to be Sum.

lib/dashboard.js Outdated
properties: {
view: 'timeSeries',
stacked: false,
title: 'Scaling as a function of the rate of processing',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since scaling isn't triggered by the rate of processing, I think the use of as a function of here is misleading. Could we change the name of this title to something like Concurrency vs. Throughput, or possibly Capacity vs. Progress

Taking a step back, do we need this graph? We have the capacity on the graph above, and the NumberOfMessagesDeleted to the left of this graph. I feel like this graph may confuse people.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho this graph is the most useful, since this is the one most of us used for understanding scaling behaviour, and I feel pretty strongly about keeping it for that reason to spare folks the effort and time of generating it/figuring out what metrics are most relevant to generate this.

👍 on the name change and the statistic comments. I need to do a final check of the names and statistics - will fix these.

@arunasank
Copy link
Contributor Author

@jakepruitt I also want to add some DeadLetterQueue metrics, specifically the ApproximateNumberOfMessagesVisible and ApproximateNumberOfMessagesNotVisible! Will do that.

@arunasank arunasank merged commit 36e8b80 into master Jun 19, 2018
@arunasank arunasank deleted the dashboard branch June 19, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants