Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove watchbot-log binary #227

Merged
merged 9 commits into from
Jun 21, 2018
Merged

Remove watchbot-log binary #227

merged 9 commits into from
Jun 21, 2018

Conversation

arunasank
Copy link
Contributor

Quick PR to have the watchbot binary perform both listen and log tasks. We can deprecate the watchbot-log binary since it is not backward-compatible anyway, owing to the Node 7.6+ dependency of the Logger class.

cc/ @mapbox/platform-engine-room

@arunasank arunasank changed the title Adds a log option Remove watchbot-log binary Jun 20, 2018
@arunasank
Copy link
Contributor Author

Per #202 (comment), I've deleted the watchbot-log binary from watchbot (4) 4ever! We should record this deprecation in our docs.

Copy link

@jakepruitt jakepruitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks great!

@arunasank arunasank merged commit 1a9df58 into master Jun 21, 2018
@YannickMeeus YannickMeeus deleted the logger-unify branch March 23, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants