Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind this reference #250

Merged
merged 4 commits into from
Jul 6, 2018
Merged

bind this reference #250

merged 4 commits into from
Jul 6, 2018

Conversation

brendanmcfarland
Copy link
Contributor

Looking to address an error we've seen on the heartbeat:

(node:1) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'queueError' of undefined
    at Timeout.heartbeat [as _onTimeout] (/snapshot/ecs-watchbot/lib/message.js:82:19)
    at ontimeout (timers.js:498:11)
    at tryOnTimeout (timers.js:323:5)
    at Timer.listOnTimeout (timers.js:290:5)

Looks related to how setInterval handles this

cc: @jakepruitt

@brendanmcfarland
Copy link
Contributor Author

@jakepruitt mind giving this a quick review - was able to replicate the error above with master, and this fix seems to have eliminated the undefined this. Worked with the initial message a worker processed and each of the subsequent ones.

Copy link

@jakepruitt jakepruitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@brendanmcfarland brendanmcfarland merged commit 84f6036 into master Jul 6, 2018
@brendanmcfarland brendanmcfarland deleted the fix-this-ref branch July 13, 2018 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants