Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combo metric #267

Merged
merged 16 commits into from
Jul 13, 2018
Merged

Combo metric #267

merged 16 commits into from
Jul 13, 2018

Conversation

jakepruitt
Copy link

Combines the MessagesVisible and MessagesNotVisible metrics into a minutely TotalMessages metric that we should scale on.

cc/ @rclark @brendanmcfarland

@brendanmcfarland
Copy link
Contributor

Shoot I knew there was a reason I didn't use node 8 in the custom resource inline lambda...

ZipFile can only be used when Runtime is set to either of nodejs, nodejs4.3, nodejs6.10, python2.7, python3.6

@jakepruitt can remove the node8 awaits etc in the code and use 6.10, or use a different code param like an S3 bucket/key

@rclark
Copy link
Contributor

rclark commented Jul 13, 2018

ZipFile can only be used when Runtime is set to either of nodejs, nodejs4.3, nodejs6.10, python2.7, python3.6

This makes me nauseous

@jakepruitt jakepruitt merged commit a32c5b4 into master Jul 13, 2018
@jakepruitt jakepruitt deleted the combo-metric branch July 13, 2018 21:12
@jakepruitt jakepruitt mentioned this pull request Jul 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakepruitt @brendanmcfarland @rclark