Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally remove deadletter alarm #288

Merged
merged 5 commits into from
Sep 14, 2018
Merged

optionally remove deadletter alarm #288

merged 5 commits into from
Sep 14, 2018

Conversation

mapsam
Copy link
Member

@mapsam mapsam commented Sep 7, 2018

This adds a deadletterAlarm option to provide a way to bypass creating the deadletter queue alarm resource. Resolves #287

Tests: wasn't sure how to properly test since there's only a single template snapshot. Is it worth creating a second snapshot without the alarm resource?

cc @mapbox/platform

@mapsam mapsam requested a review from a team September 7, 2018 23:08
Copy link
Contributor

@vsmart vsmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@mapsam
Copy link
Member Author

mapsam commented Sep 14, 2018

Thanks @vsmart! Going to do a dev release to test out first, and will report back.

@mapsam
Copy link
Member Author

mapsam commented Sep 14, 2018

Confirmed that template diffs no longer include the alarm resource!


---------------------------------------------

       },
       "Type": "AWS::CloudWatch::Dashboard"
     },
-    "WatchbotDeadLetterAlarm": {
-      "Properties": {
-        "AlarmActions": [
-          {
-            "Ref": "WatchbotNotificationTopic"
-          }
-        ],
-        "AlarmDescription": "Provides notification when messages are visible in the dead letter queue",
-        "AlarmName": {
-          "Fn::Join": [
-            "-",
-            [
-              {
-                "Ref": "AWS::StackName"
-              },
-              "Watchbot-dead-letter"
-            ]
-          ]
-        },
-        "ComparisonOperator": "GreaterThanOrEqualToThreshold",
-        "Dimensions": [
-          {
-            "Name": "QueueName",
-            "Value": {
-              "Fn::GetAtt": [
-                "WatchbotDeadLetterQueue",
-                "QueueName"
-              ]
-            }
-          }
-        ],
-        "EvaluationPeriods": 1,
-        "MetricName": "ApproximateNumberOfMessagesVisible",
-        "Namespace": "AWS/SQS",
-        "Period": "60",
-        "Statistic": "Minimum",
-        "Threshold": 1
-      },
-      "Type": "AWS::CloudWatch::Alarm"
-    },
     "WatchbotDeadLetterQueue": {
       "Description": "List of messages that failed to process 14 times",
       "Properties": {

---------------------------------------------

Merging and releasing as 4.12.0 🎉

@mapsam mapsam merged commit 00b594b into master Sep 14, 2018
@mapsam mapsam deleted the no-deadletter-alarm branch September 14, 2018 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants