Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring final image format #7

Merged
merged 3 commits into from Apr 10, 2018
Merged

Allow configuring final image format #7

merged 3 commits into from Apr 10, 2018

Conversation

lukasmartinelli
Copy link
Contributor

@lukasmartinelli lukasmartinelli commented Apr 9, 2018 •
edited

Allows to switch between jpg and png.
We should squash merge this.

TODO:

  • Test publish this library and test in downstream dependencies @lukasmartinelli

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 87.356% when pulling ce81b32 on configure-encoding-options into f22bdaa on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 87.356% when pulling ce81b32 on configure-encoding-options into f22bdaa on master.

@amishas157 amishas157 self-requested a review April 9, 2018 07:47
amishas157
amishas157 approved these changes Apr 10, 2018
View reviewed changes
Copy link

@amishas157 amishas157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@lukasmartinelli lukasmartinelli merged commit 662e859 into master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amishas157 amishas157 amishas157 approved these changes

Assignees

@lukasmartinelli lukasmartinelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukasmartinelli @coveralls @amishas157