Handle feature id 0 #107
Merged
Handle feature id 0 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Jun 27, 2018
|
Great work @ChrisLoer, I just ran into this in GL JS wondering why one of my feature's wasn't working with feature-states, turns out it was the unlucky feature to get an id of 0. Easy to workaround by starting feature IDs from 1, but would be nice to have this in a geojson-vt release and updated in mapbox-gl-js for the next release. |
|
@andrewharvey thanks for the reminder! Just published v3.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran into an odd test discrepancy between mapbox gl-native and gl-js and tracked it down to geojson-vt treating a feature with id of "0" as if it doesn't have an id.
We could alternatively get a little stricter and require it to be a number or a string? (as in: https://github.com/mapbox/geometry.hpp/blob/cfcb983f3571269653467f0a679bd956366c101e/include/mapbox/geometry/feature.hpp#L47)
/cc @mourner