-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo app #30
Add demo app #30
Conversation
a052e5e
to
0188a3d
Compare
annotations-framework-extension/annotationapp/Controllers/MapViewController.swift
Outdated
Show resolved
Hide resolved
be1fabb
to
94d58d6
Compare
a479c16
to
a71a4ec
Compare
I'm going to leave the features introduced from #43 for a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I have two main architecture observations:
For delegate implementations try to follow the pattern:
extension ClassName: DelegateName {
...
}
When returning the updated view, avoid using willMove
and move that logic to the controller.
I found two bugs:
In the line style annotations when you pick a different color then close then chose again the annotation it resets the previous selected value.
On non iPhone X phones the content insets at the bottom are wrong.
annotations-framework-extension/annotationapp/ViewController.swift
Outdated
Show resolved
Hide resolved
annotations-framework-extension/annotationapp/Controllers/MapViewController.swift
Outdated
Show resolved
Hide resolved
...framework-extension/annotationapp/Controllers/Protocols/PresentationControllerDelegate.swift
Show resolved
Hide resolved
annotations-framework-extension/annotationapp/Views/Settings/CircleSettingsView.swift
Outdated
Show resolved
Hide resolved
4b2bacf
to
9edcb29
Compare
annotations-framework-extension/annotationapp/Controllers/MapViewController.swift
Outdated
Show resolved
Hide resolved
7f246a2
to
1341b3f
Compare
@fabian-guerra I pulled in #47 in 1341b3f which fixes this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, and almost done. There are three remaining issues:
- If you select the label and change only the font color it changes the icon color too.
- If you select one annotation then select another then hold and drag the previous annotation it duplicates that annotation.
- Is not possible to change the icon rotation in non iPhoneX phones.
annotations-framework-extension/annotationapp/Controllers/MapViewController.swift
Outdated
Show resolved
Hide resolved
b8651c4
to
0241c01
Compare
Fix file paths, remove unused storybaord vc Address feedback Fix file name whyyy
Weird
0241c01
to
4782b93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
✨ Workin on it ✨