Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to system locale #202

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Default to system locale #202

merged 1 commit into from
Nov 9, 2017

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Nov 9, 2017

Default to the autoupdating current system locale for instructions and spoken instructions. (Locale.autoupdatingCurrent differs from Locale.current only on macOS, where it’s possible to change the system language or region without restarting the system.)

RouteOptions.locale is no longer optional, which is technically a backwards-incompatible change in Swift.

Fixes #201.

/cc @bsudekum @frederoni

@1ec5 1ec5 added the improvement Improvement for an existing feature. label Nov 9, 2017
@1ec5 1ec5 self-assigned this Nov 9, 2017
@1ec5 1ec5 merged commit 4488a7f into master Nov 9, 2017
@1ec5 1ec5 deleted the 1ec5-locale-default-201 branch November 9, 2017 18:45
@1ec5 1ec5 mentioned this pull request Nov 9, 2017
@1ec5 1ec5 added the backwards incompatible changes that break backwards compatibility of public API label Dec 18, 2018
@1ec5 1ec5 added this to the v0.12.0 milestone Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards incompatible changes that break backwards compatibility of public API improvement Improvement for an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants