Add abbreviation support #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsudekum
commented
Feb 27, 2018
| /** | ||
| The priority in which the component should be abbreviated. Lower numbers should be abbreviated first. | ||
| */ | ||
| @objc public var abbreviationPriority: Int |
There was a problem hiding this comment.
Although this property is optional, objc does not support optional Ints. Because of this, the default value will be zero. Anyone have objections here?
There was a problem hiding this comment.
No concerns from me. Just noting that abbr_priority: 0 is the highest priority, so you might have to add a check to excludes abbreviations where abbr is undefined when putting abbreviations together.
There was a problem hiding this comment.
On second thought, I think it's important it is optional. Going to use NSNumber.
There was a problem hiding this comment.
Changed the default value to Int.max since zero would be incorrect.
2 tasks
|
@mapbox/navigation-ios this is ready for review. |
1ec5
added
backwards incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for abbreviations.
Going to update fixture and tests dependent on which ever can merge first between this PR and #243
/cc @mapbox/navigation-ios @danpaz