Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit, exitNumber component types #252

Merged
merged 2 commits into from
Apr 3, 2018
Merged

Add exit, exitNumber component types #252

merged 2 commits into from
Apr 3, 2018

Conversation

bsudekum
Copy link

@bsudekum bsudekum commented Apr 2, 2018

Adda .exit, .exitNumber to MBVisualInstructionType.

/cc @1ec5 @JThramer

@@ -23,6 +23,16 @@ public enum VisualInstructionComponentType: Int, CustomStringConvertible {
*/
case image

/**
The compoment contains the localized word for "exit".
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component may appear before or after an .exitNumber component, depending on the language.

/**
A component contains an exit number.
*/
case exitNumber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this property to exitCode for consistency with RouteStep.exitCode:

https://github.com/mapbox/MapboxDirections.swift/blob/1711560166601f46466391a21da1ff79f2727323/MapboxDirections/MBRouteStep.swift#L882-L889

This property was so named to avoid confusion with a preexisting exitIndex and also because a freeway exit number may be alphabetic or alphanumeric.

@bsudekum bsudekum merged commit ef146fa into master Apr 3, 2018
@bsudekum bsudekum deleted the exits branch April 3, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants