Fix segment indices #587
Merged
Fix segment indices #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamx23
force-pushed
the
bamx23/fix-segment-indices
branch
from
b0edd93
to
443334f
Compare
|
@bamx23 Do we have an issue that will be fixed by fix PR? |
We do, but it's in a private repo, linked. |
bamx23
force-pushed
the
bamx23/fix-segment-indices
branch
from
443334f
to
162b742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with
segmentRangesByStephaving the wrong range for the arrival step. Instead of being empty, it had the length of 2 as the arrival step in real responses has a geometry that is a line with the same two points (zero-length line).cc: @1ec5