RouteLeg.closures integration #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…responding parameter to RouteLeg; added new annotation request to DirectionsOptions; Added single refresh method to cover refreshing all types of entities; unit tests updated;
Udumft
commented
Oct 21, 2022
| @@ -1 +1,2 @@ | |||
|
|
|||
| API breakage: enumelement RouteLeg.CodingKeys.closures has been added as a new enum case | |||
There was a problem hiding this comment.
Adding new annotation type is impossible without adding new enum element...
Udumft
commented
Oct 21, 2022
| @@ -1 +1,2 @@ | |||
|
|
|||
| API breakage: enumelement RouteLeg.CodingKeys.closures has been added as a new enum case | |||
| API breakage: var RouteLegRefreshSource.refreshedClosures has been added as a protocol requirement | |||
There was a problem hiding this comment.
Mitigated by default extension implementation.
kried
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for RouteLeg Closures. Added corresponding type, properties in RouteLeg and DirectionsOptions. Also updated refreshing methods for the new updated info. Refreshing also refined a bit by introducing single refresh method with flexible configuration which should cover possible variations and reduce amount of user code for refreshing routes.