Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Core and Telemetry Release #131

Merged
merged 16 commits into from
May 2, 2018
Merged

Conversation

electrostat
Copy link
Contributor

@electrostat electrostat commented May 1, 2018

Create a process to easily decouple the release of Core and Telemetry libraries

fixes #125

- create and check variables and how they work within CircleCi
@electrostat electrostat self-assigned this May 1, 2018
- testing new release check for repo urls
- move println so it actually shows up witin test
- test "false" with core
- testing snapshot upload
- creating abort release
- test
- new exception testing
- check in signing to go up food chain
- use stopactionexception to gracefully kill upload
- remove upload check
- split core and telem gradle commands
- remove comment prevent circleci from running
- use echo notation to trigger desired result
- add 'true' comparisons
- remvoe 'echo' from if statments
- add parentheses around variables
- fixed spacing
- remove unused code attempts
- revert to using master for publishing
@zugaldia
Copy link
Member

zugaldia commented May 1, 2018

Thanks for running with this. Could you post a quick comment explaining how the new process would work now (i.e. how to release one library not the other)?

@electrostat
Copy link
Contributor Author

@zugaldia

As default, OK_TO_RELEASE_CORE and OK_TO_RELEASE_TELEM are hardcoded as true within the CircleCi config file. When you want to release only one of the libraries, we change the value of the opposite library (as in releasing telem w/o core, we change the OK_TO_RELEASE_CORE to false). I tested this by releasing SNAPSHOTS from this branch. When done, just revert back before merging back to master.

This should be an additional step to check on our release checklist.

Copy link
Member

@zugaldia zugaldia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo on mvn-push-android.gradle, otherwise 🚀

@@ -54,6 +54,7 @@ afterEvaluate { project ->
uploadArchives {
repositories {
mavenDeployer {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems accidental.

- remove added blank line
@electrostat electrostat merged commit 5f74fee into master May 2, 2018
@electrostat electrostat deleted the aa-decouple-releases branch May 2, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple Core and Telem Release Process
2 participants