Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make location event constructor package private #155

Merged
merged 1 commit into from
May 25, 2018
Merged

Make location event constructor package private #155

merged 1 commit into from
May 25, 2018

Conversation

Guardiola31337
Copy link
Contributor

  • Makes LocationEvent constructor package-private

@Guardiola31337 Guardiola31337 self-assigned this May 25, 2018
@Guardiola31337 Guardiola31337 merged commit db770e5 into master May 25, 2018
@Guardiola31337 Guardiola31337 deleted the pg-location-event-package-private branch May 25, 2018 16:38
@zugaldia
Copy link
Member

Isn't this considered a SEMVER change?

@Guardiola31337
Copy link
Contributor Author

Isn't this considered a SEMVER change?

Nah, I'd say it was a bug fix. LocationEvent was only used internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrostat electrostat electrostat approved these changes

Assignees

@Guardiola31337 Guardiola31337

Labels
enhancement ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Guardiola31337 @zugaldia @electrostat