TelemetryLocationEnabler Null Bug #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- initialize telemetryLocationEnabler if it is null at this point
Guardiola31337
requested changes
May 28, 2018
There was a problem hiding this comment.
Noting here that this PR fixes #147
Other than 👇 looks good to me.
| @@ -239,6 +239,10 @@ private void unregisterTelemetryReceiver() { | |||
|
|
|||
| private void disableTelemetryLocationState() { | |||
| if (isLocationEnablerFromPreferences) { | |||
| if (telemetryLocationEnabler == null) { | |||
| telemetryLocationEnabler = new TelemetryLocationEnabler(true); | |||
There was a problem hiding this comment.
Could you extract a Lazy initialization method as suggested here #147 (comment)?
We could extract a Lazy initialization method and use it accordingly in both call sites (when enabling and disabling).
- extract out check logic into separate method - include method within `enableTelemetryLocationState` to prevetn duplicate code
Guardiola31337
approved these changes
Jun 4, 2018
| @@ -253,6 +250,12 @@ private void checkApplicationContext() { | |||
| } | |||
| } | |||
|
|
|||
| private void checkLocationEnabler() { | |||
There was a problem hiding this comment.
As we're creating a new instance of TelemetryLocationEnabler if not already created, what about calling this method createLocationEnabler instead?
- rename method to `createLocationEnabler`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances,
TelemetryLocationEnableris null. Add in check to initialize, before being used.