Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash When Disabling Location Permissions Manually #184

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

electrostat
Copy link
Contributor

@electrostat electrostat commented Jul 18, 2018

Our SDK currently crashes when a user disables location permissions manually (through the Android settings) and returns to the parent application. LocationEngine is attempting to acquire location without permission.

Change was to add in both pre and post api 23 permission check before activating the engine.

Fixes #182 (comment)

- check permission before activating locationEngine
- use both pre and post api 23 permission checks
@electrostat electrostat self-assigned this Jul 18, 2018
@electrostat electrostat requested a review from tobrun July 18, 2018 22:11
@ufocom
Copy link

ufocom commented Jul 19, 2018

Hi, where/when i can find fix for this little bug?

@electrostat electrostat merged commit 51ec82d into master Jul 23, 2018
@electrostat electrostat deleted the aa-location-permission-off-crash branch July 23, 2018 15:04
@electrostat
Copy link
Contributor Author

electrostat commented Jul 23, 2018

@ufocom I just pushed this. You can check the latest 3.2.0-Snapshot of the Telemetry library LINK. We will work on getting it into the next maps sdk release.

@ufocom
Copy link

ufocom commented Aug 1, 2018

@electrostat so if i will add telemetry lib to my gradly problem will be solved?

@electrostat
Copy link
Contributor Author

@ufocom yes. As long as you exclude the telemetry and core libraries from the maps sdk. I will be doing a release today and then the maps team is looking to incorporate that into a release they are going to do shortly. So you can either exclude and add or wait for the next release.

@ursimon
Copy link

ursimon commented Aug 15, 2018

to be more specific, this has resolved my issue:

implementation('com.mapbox.mapboxsdk:mapbox-android-sdk:6.1.3') {
        exclude group: 'com.mapbox.android.core'
        exclude group: 'com.mapbox.android.telemetry'
    }
    implementation 'com.mapbox.mapboxsdk:mapbox-android-telemetry:3.2.0-SNAPSHOT'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants