Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline maps event #193

Merged
merged 2 commits into from
Oct 3, 2018
Merged

Offline maps event #193

merged 2 commits into from
Oct 3, 2018

Conversation

zugaldia
Copy link
Member

@zugaldia zugaldia commented Aug 3, 2018

This PR adds a new MapOfflineEvent event to the Maps SDK list of events.

It's still a WIP - not all fields are finalized, and tests are missing.

cc: @electrostat @Guardiola31337 for early eyes.

@asheemmamoowala
Copy link

@zugaldia #11447 adds support for shapes to define offline regions. In addition to the bounding box, it would be helpful if the telemetry data also collects the zoom range and geometry type (for shape-based regions).

With the geometry type, it would be helpful to understand how developers use the offline regions - for example - routes vs admin boundaries.

@zugaldia
Copy link
Member Author

zugaldia commented Aug 6, 2018

@asheemmamoowala totally, thanks for linking the ongoing work. For now this WIP PR is targeting the fields in OfflineRegionDefinition which is the base interface we use for all regions, and it only has knowledge of bounds. I'm definitely interested in adding more fields, to support mapbox/mapbox-gl-native#11447 and the current OfflineTilePyramidRegionDefinition.

@zugaldia zugaldia self-assigned this Aug 14, 2018
@osana osana force-pushed the az-offline-event branch 2 times, most recently from 592d21c to bb345b2 Compare October 3, 2018 16:17
@osana osana requested a review from electrostat October 3, 2018 16:22
@osana osana assigned osana and unassigned zugaldia Oct 3, 2018
@@ -21,6 +21,7 @@
private static final int NO_NETWORK = -1;
private static final String NOT_A_LOAD_MAP_EVENT_TYPE = "Type must be a load map event.";
private static final String NOT_A_GESTURE_MAP_EVENT_TYPE = "Type must be a gesture map event.";
private static final String NOT_AN_OFFLINE_MAP_EVENT_TYPE = "Type must be an offline map event.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed, since we are no longer worried about type for this event during creation.

@osana osana merged commit 4dbb123 into master Oct 3, 2018
@osana osana deleted the az-offline-event branch October 3, 2018 17:32
@mapbox mapbox deleted a comment from osana Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants