-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline maps event #193
Offline maps event #193
Conversation
@zugaldia #11447 adds support for shapes to define offline regions. In addition to the bounding box, it would be helpful if the telemetry data also collects the zoom range and geometry type (for shape-based regions). With the geometry type, it would be helpful to understand how developers use the offline regions - for example - routes vs admin boundaries. |
@asheemmamoowala totally, thanks for linking the ongoing work. For now this WIP PR is targeting the fields in |
592d21c
to
bb345b2
Compare
bb345b2
to
2c40613
Compare
@@ -21,6 +21,7 @@ | |||
private static final int NO_NETWORK = -1; | |||
private static final String NOT_A_LOAD_MAP_EVENT_TYPE = "Type must be a load map event."; | |||
private static final String NOT_A_GESTURE_MAP_EVENT_TYPE = "Type must be a gesture map event."; | |||
private static final String NOT_AN_OFFLINE_MAP_EVENT_TYPE = "Type must be an offline map event."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be removed, since we are no longer worried about type for this event during creation.
in event-schema repe
2c40613
to
696b41f
Compare
This PR adds a new
MapOfflineEvent
event to the Maps SDK list of events.It's still a WIP - not all fields are finalized, and tests are missing.
cc: @electrostat @Guardiola31337 for early eyes.