More specific Proguard rules #217
Conversation
- make proguard rules more specific - target location and core, which we use within CORE
libcore/proguard-consumer.pro
Outdated
| @@ -1,5 +1,6 @@ | |||
| # Consumer proguard rules for libcore | |||
|
|
|||
| # --- GMS --- | |||
| -keep class com.google.android.gms.** { *; } | |||
| -keep class com.google.android.gms.location.** { *; } | |||
| -keep class com.google.android.gms.common.** { *; } | |||
There was a problem hiding this comment.
what is the reason for keeping these classes? Are you using reflection on these or any other reason why they should be kept?
There was a problem hiding this comment.
Per @LukasPaczos comment on the original PR that started this Proguard change (#81 (comment)). This is necessary to prevent warnings in the maps sdk when building for release.
There was a problem hiding this comment.
True. However, we should only keep the required ones, or maybe we can even dontwarn some of those?
There was a problem hiding this comment.
We could remove the keep and then keep the dontwarn. Does that implementation work for you two, without having any negative effects on the maps sdk?
There was a problem hiding this comment.
Refs https://developers.google.com/android/guides/setup:
Note: ProGuard directives are included in the Play services client libraries to preserve the required classes. The Android Plugin for Gradle automatically appends ProGuard configuration files in an AAR (Android ARchive) package and appends that package to your ProGuard configuration. During project creation, Android Studio automatically creates the ProGuard configuration files and build.gradle properties for ProGuard use. To use ProGuard with Android Studio, you must enable the ProGuard setting in your build.gradle buildTypes. For more information, see the ProGuard guide.
What I understand from there is that if you are not referencing any of those compoenents via reflection, we should be good with using only dontwarn.
There was a problem hiding this comment.
Perfect. I don't. I'll make the change.
- remove location and common keep rules, since we are not using reflection
Update proguard rules to be more specific and lower method counts. We utilize
commonandlocationwithin theCorelibrary and will keep only those.fixes #199