Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition JobIntentService to WorkManager #453

Merged
merged 7 commits into from
Feb 4, 2020

Conversation

nkukday
Copy link
Contributor

@nkukday nkukday commented Jan 22, 2020

No description provided.

@nkukday nkukday requested a review from harvsu January 22, 2020 18:44
@nkukday nkukday self-assigned this Jan 22, 2020
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #453 into master will decrease coverage by 0.01%.
The diff coverage is 78.57%.

@@             Coverage Diff              @@
##             master     #453      +/-   ##
============================================
- Coverage     68.36%   68.35%   -0.02%     
+ Complexity      394      392       -2     
============================================
  Files            69       68       -1     
  Lines          2156     2152       -4     
  Branches        171      172       +1     
============================================
- Hits           1474     1471       -3     
+ Misses          584      582       -2     
- Partials         98       99       +1

@nkukday nkukday changed the title Transition Jobintentservice to Workmanager Transition JobIntentService to WorkManager Feb 3, 2020
Copy link
Contributor

@alfwatt alfwatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nkukday nkukday merged commit fa7f7fa into master Feb 4, 2020
harvsu pushed a commit that referenced this pull request Mar 12, 2020
nkukday added a commit that referenced this pull request Mar 17, 2020
nkukday added a commit that referenced this pull request Mar 18, 2020
nkukday added a commit that referenced this pull request Mar 19, 2020
harvsu pushed a commit that referenced this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants