Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass camera options to map.fitBounds #227

Merged
merged 3 commits into from Mar 22, 2019
Merged

Pass camera options to map.fitBounds #227

merged 3 commits into from Mar 22, 2019

Conversation

scottsfarley93
Copy link

@scottsfarley93 scottsfarley93 commented Mar 21, 2019 •
edited

This PR addresses @andrewharvey 's comment here and passes the options.flyTo value set in the constructor to the map.fitBounds method when a selected feature has a bounding box.

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • run npm run docs and commit changes to API.md
  • update CHANGELOG.md with changes under master heading before merging

@scottsfarley93 scottsfarley93 changed the title Update docs to indicate that flying options will be passed to both fl… Pass camera options to map.fitBounds Mar 21, 2019
@andrewharvey andrewharvey added this to the v4.0.0 milestone Mar 21, 2019
katydecorah
katydecorah approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@katydecorah katydecorah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@scottsfarley93 scottsfarley93 merged commit 9e77770 into version4 Mar 22, 2019
@scottsfarley93 scottsfarley93 mentioned this pull request Mar 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katydecorah katydecorah katydecorah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scottsfarley93 @katydecorah @andrewharvey