Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geolocate functionality to mapbox-gl-geocoder #444

Merged
merged 11 commits into from
Mar 4, 2022
Merged

Add geolocate functionality to mapbox-gl-geocoder #444

merged 11 commits into from
Mar 4, 2022

Conversation

krydima
Copy link
Contributor

@krydima krydima commented Dec 7, 2021 •
edited

Add functionality to find user location through browser api.
Screenshot 2021-12-07 at 13 01 29

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • run npm run docs and commit changes to API.md
  • update CHANGELOG.md with changes under master heading before merging

@krydima krydima self-assigned this Dec 7, 2021
mpothier
mpothier approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@mpothier mpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - a couple minor suggestions for improving code annotations and readability, otherwise LGTM

lib/geolocation.js Outdated Show resolved Hide resolved
lib/utils.js Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
mapbox-danny
mapbox-danny reviewed Dec 7, 2021
View reviewed changes
lib/geolocation.js Outdated Show resolved Hide resolved
@mpothier mpothier merged commit 50bc7b7 into main Mar 4, 2022
@mpothier mpothier deleted the add-geolocate-user branch March 4, 2022 15:14
@raws raws mentioned this pull request Jun 20, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpothier mpothier mpothier approved these changes

@mapbox-danny mapbox-danny mapbox-danny left review comments

Assignees

@krydima krydima

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krydima @mpothier @mapbox-danny