Add 'events' package dependency #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpothier
approved these changes
Feb 2, 2022
krydima
approved these changes
Feb 21, 2022
janosh
added a commit
to sbsev/site
that referenced
this pull request
Mar 5, 2022
janosh
added a commit
to sbsev/site
that referenced
this pull request
Mar 5, 2022
janosh
added a commit
to sbsev/site
that referenced
this pull request
Mar 5, 2022
janosh
added a commit
to sbsev/site
that referenced
this pull request
Mar 5, 2022
* bump GH actions/setup-node v2 -> v3 * yarn remove cross-fetch + events (later now incl. by mapbox/mapbox-gl-geocoder#451) * includen hidden links to all contenful pages in nav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #441
New packagers like Vite don't automatically replace Node packages (
events) with their browser equivalents, so this PR just installs theeventsNPM package so our code always has a fallback.npm run docsand commit changes to API.mdmasterheading before merging