Flattens nested single element all expressions when converting to exp…

…ressions (#7679)
mapbox · Dec 11, 2018 · 1e51f5c · 1e51f5c
1 parent 0f370bf
commit 1e51f5c
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 1 deletion.
diff --git a/src/style-spec/feature_filter/convert.js b/src/style-spec/feature_filter/convert.js
@@ -92,7 +92,7 @@ function _convertFilter(filter: FilterSpecification, expectedTypes: ExpectedType
         return ['any'].concat(children);
     } else if (op === 'all') {
         const children = (filter: any).slice(1).map(f => _convertFilter(f, expectedTypes));
-        return ['all'].concat(children);
+        return children.length > 1 ? ['all'].concat(children) : [].concat(...children);
     } else if (op === 'none') {
         return ['!', _convertFilter(['any'].concat(filter.slice(1)), {})];
     } else if (op === 'in') {

diff --git a/test/unit/style-spec/feature_filter.test.js b/test/unit/style-spec/feature_filter.test.js
@@ -100,6 +100,45 @@ test('convert legacy filters to expressions', t => {
         t.end();
     });
 
+    t.test('flattens nested, single child all expressions', (t) => {
+        const filter = [
+            "all",
+            [
+                "in",
+                "$type",
+                "Polygon",
+                "LineString",
+                "Point"
+            ],
+            [
+                "all",
+                ["in", "type", "island"]
+            ]
+        ];
+
+        const expected = [
+            "all",
+            [
+                "match",
+                ["geometry-type"],
+                ["Polygon", "LineString", "Point"],
+                true,
+                false
+            ],
+            [
+                "match",
+                ["get", "type"],
+                ["island"],
+                true,
+                false
+            ]
+        ];
+
+        const converted = convertFilter(filter);
+        t.same(converted, expected);
+        t.end();
+    });
+
     t.end();
 });