Merge pull request #1456 from mapbox/1443-lnglat-throw

Throw on lat > 90 || < -90. Fixes #1443
mapbox · Sep 7, 2015 · 6e29593 · 6e29593
2 parents a459632 + 2c2bd6e
commit 6e29593
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/js/geo/lng_lat.js b/js/geo/lng_lat.js
@@ -20,6 +20,9 @@ function LngLat(lng, lat) {
     }
     this.lng = +lng;
     this.lat = +lat;
+    if (this.lat > 90 || this.lat < -90) {
+        throw new Error('Invalid LngLat latitude value: must be between -90 and 90');
+    }
 }
 
 /**

diff --git a/test/js/geo/lng_lat.test.js b/test/js/geo/lng_lat.test.js
@@ -10,6 +10,14 @@ test('LngLat', function(t) {
             /*eslint no-new: 0*/
             new LngLat('foo', 0);
         }, "Invalid LngLat object: (foo, 0)", 'detects and throws on invalid input');
+        t.throws(function() {
+            /*eslint no-new: 0*/
+            new LngLat(0, -91);
+        }, 'Invalid LngLat latitude value: must be between -90 and 90', 'detects and throws on invalid input');
+        t.throws(function() {
+            /*eslint no-new: 0*/
+            new LngLat(0, 91);
+        }, 'Invalid LngLat latitude value: must be between -90 and 90', 'detects and throws on invalid input');
         t.end();
     });