Forbid class fields to fix transpilation errors with Vite/ESBuild (#1…

…2658) * forbid class fields to fix transpilation errors with vite/esbuild * fix flow
mapbox · Apr 14, 2023 · a090df0 · a090df0
1 parent c76789e
commit a090df0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -27,6 +27,9 @@
     "no-duplicate-imports": "off",
     "import/no-duplicates": "error",
 
+    // prevent issues with esbuild/vite https://github.com/mapbox/mapbox-gl-js/issues/12656
+    "no-restricted-syntax": ["error", "ClassProperty[value]"],
+
     // ensure compatibility with Node's native ESM
     "import/extensions": ["error", {
       "js": "always",

diff --git a/src/style/style_layer/line_style_layer.js b/src/style/style_layer/line_style_layer.js
@@ -22,7 +22,7 @@ import type {TilespaceQueryGeometry} from '../query_geometry.js';
 import type {IVectorTileFeature} from '@mapbox/vector-tile';
 
 class LineFloorwidthProperty extends DataDrivenProperty<number> {
-    useIntegerZoom = true;
+    useIntegerZoom: ?boolean;
 
     possiblyEvaluate(value, parameters) {
         parameters = new EvaluationParameters(Math.floor(parameters.zoom), {

diff --git a/test/unit/util/util.test.js b/test/unit/util/util.test.js
@@ -69,13 +69,14 @@ test('util', (t) => {
                 this.name = 'Tom';
             }
 
-            ontimer = () => {
+            ontimer() {
                 t.equal(this.name, 'Tom');
                 t.end();
             }
         }
 
         const my = new MyClass();
+        // $FlowFixMe[method-unbinding]
         setTimeout(my.ontimer, 0);
     });