New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Both minified & unminified style specs are included in bundle #2997

Closed

tmcw opened this issue Aug 12, 2016 · 0 comments

Labels

Contributor

tmcw commented Aug 12, 2016

We require validate_style.min here https://github.com/mapbox/mapbox-gl-js/blob/master/js/style/validate_style.js#L3

and the latest style spec here https://github.com/mapbox/mapbox-gl-js/blob/master/js/style/style_spec.js#L3

As a result, we include both v8.json and v8.min.json. This adds about 18kb of wasted code to GL JS.

tmcw added the bug 🐞 label

tmcw added a commit that referenced this issue


          Require min style in both places. Fixes #2997

63ab85f

tmcw closed this as completed in

50142de

tmcw mentioned this issue

Do we need min JSON files in gl-style-spec? mapbox/mapbox-gl-style-spec#609

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment