Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/debug label placement looks broken #436

Closed
tmcw opened this issue Jun 9, 2014 · 3 comments
Closed

/debug label placement looks broken #436

tmcw opened this issue Jun 9, 2014 · 3 comments
Labels
bug 🐞

Comments

@tmcw
Copy link
Contributor

tmcw commented Jun 9, 2014

2014-06-09 at 12 02 pm

Is this expected behavior? Maybe these labels are missized?
@tmcw tmcw added the bug label Jun 9, 2014
@yhahn
Copy link
Member

yhahn commented Jun 9, 2014

Expected atm

https://github.com/mapbox/llmr/blob/master/debug/style.js#L116

Not sure when this was set to this but it's been this way for a while.

@mourner
Copy link
Member

mourner commented Jun 9, 2014

Yeah it's a hack that makes llmr not check for collisions for a particuar label, which sort of fixes some issues but causes another ones. We should get rid of this property I think, and instead look into optimizing label placement more.

@mourner
Copy link
Member

mourner commented Jun 24, 2014

Not on debug anymore. Also see #486

@mourner mourner closed this as completed Jun 24, 2014
bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this issue Oct 24, 2016
@mcwhittemore
Merge pull request mapbox#436 from mapbox/mode-handler-tests
74cdafc 
Mode handler tests; closes mapbox#370
karimnaaji pushed a commit that referenced this issue Mar 14, 2023
@alexey-romanov
[MAPS3D-691] line borders: respect lighting and fog (#436)
9305d1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mourner @tmcw @yhahn