Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older versions of chrome text rendering breaks (chrome 48) #8742

Closed
baversjo opened this issue Sep 9, 2019 · 7 comments · Fixed by #9349
Closed

Older versions of chrome text rendering breaks (chrome 48) #8742

baversjo opened this issue Sep 9, 2019 · 7 comments · Fixed by #9349

Comments

@baversjo
Copy link

baversjo commented Sep 9, 2019

mapbox-gl-js version:

  1. 1.3.1 (and whatever runs on your site)

browser:
chrome 48 on osx

Steps to Trigger Behavior

  1. Download this older version of chrome, chrome 48: https://sourceforge.net/projects/osxportableapps/files/Chromium/Chromium_OSX_48.0.2564.116.dmg/download
  2. goto your simple example: https://docs.mapbox.com/mapbox-gl-js/example/simple-map/
  3. see how text is incorrectly rendered:

Screenshot 2019-09-09 16 00 34

Expected Behavior

Text should render in correct size

Actual Behavior

text is rendered in huge size

@baversjo
Copy link
Author

baversjo commented Sep 9, 2019

Mapbox gl 0.45 works perfectly on chrome 48 by the way.

@baversjo
Copy link
Author

baversjo commented Sep 9, 2019

the reason I'm filing this is because I have devices using mapbox gl on android 4.4 and they're stuck on this version of chrome and are affected by this.

@baversjo
Copy link
Author

baversjo commented Sep 9, 2019

if you do not want to solve this bug maybe you would consider disabling showing text on older versions of chrome so at least the map renders?

@igal1c0de4n
Copy link

igal1c0de4n commented Feb 8, 2020

Maps on chrome versions < 48 seem useless.
Until it's fixed, a useful change for those of us who rely on mapboxgl.supported() : return false for the browser-versions in which the problem occurs.
Team: can you make this change?

@kkaefer
Copy link
Contributor

kkaefer commented Feb 26, 2020

Mapbox gl 0.45 works perfectly on chrome 48 by the way.

I tried this, but 0.45 has the same rendering error on Chrome 48.

@kkaefer
Copy link
Contributor

kkaefer commented Feb 26, 2020

The last version that was still working correctly is 0.34. The commit that starts failing in Chrome 48 is 13363a2, as part of #4455.

@baversjo
Copy link
Author

@kkaefer thank you so much for finding a fix for this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants