Add source field requirement to terrain exaggeration #11664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimnaaji
reviewed
Apr 4, 2022
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ### 🐞 Bug fixes | |||
|
|
|||
| * Add source field requirement to terrain exaggeration ([#11664](https://github.com/mapbox/mapbox-gl-js/pull/11664)) | |||
There was a problem hiding this comment.
@tristen Could you remove that from the actual changelog file and add it to the PR description?
Our process for changelog is to compile it before the release. And we have a CI check that looks on the description and fails if it's not marked with the label 'skip changelog'
PR looks good otherwise!
karimnaaji
approved these changes
Apr 5, 2022
ansis
pushed a commit
that referenced
this pull request
Apr 11, 2022
* Add source field requirement to terrain exaggeration * Changelog entry * Remvoe entry from CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapbox-gl-jschangelog:<changelog>Addsourcefield requirement to terrain exaggeration. </changelog>