Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization for UI strings in German #11694

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Add localization for UI strings in German #11694

merged 4 commits into from
Apr 12, 2022

Conversation

stepankuzmin
Copy link
Contributor

Hey 👋

This PR adds translations for UI strings we use in GL JS into German. We translated the UI strings automatically using the Google Translate API, and we need to verify that the translation is correct.

To help us verify the translations, you can open the Files changed tab on this page and compare the translations with the original file src/ui/default_locale.js.

If the translation looks good, you can approve it using the Review changes button in the Files changed tab and selecting the Approve radio button when submitting the review.

To improve the machine translation, you can click the plus sign next to the line you want to enhance and select the suggestion button on the toolbar.

After making the suggestions, you can mark the review as finished using the Review changes button and selecting the Request changes radio button.

Thanks for helping 🙌

@stepankuzmin stepankuzmin added the skip changelog Used for PRs that do not need a changelog entry label Apr 11, 2022
src/ui/locales/de.js Outdated Show resolved Hide resolved
src/ui/locales/de.js Outdated Show resolved Hide resolved
src/ui/locales/de.js Outdated Show resolved Hide resolved
src/ui/locales/de.js Outdated Show resolved Hide resolved
Copy link
Contributor

@kkaefer kkaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This translation uses the formal “Sie”. A less formal translation is probably okay in most contexts as well. An alternative could be to offer a formal and an informal translation and let users select.

src/ui/locales/de.js Outdated Show resolved Hide resolved
"NavigationControl.ResetBearing": "Setzen Sie die Peilung auf Nord zurück",
"NavigationControl.ZoomIn": "Hineinzoomen",
"NavigationControl.ZoomOut": "Rauszoomen",
"ScaleControl.Feet": "ft",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s no commonly used abbreviation for this. The full word is “Fuß”

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but I think that is due to the fact that it is this unit which is not commonly used in the first place, so it's abbreviation isn't either. If however, "Fuß" happens to be used as a unit in German, then I think ft would be the correct abbreviation. Actually, abbreviation is not the correct term here, I think. It rather is a symbol that happens to be an abbreviation in this case. Consider e.g. cm or µm which are not really abbreviations for Zentimeter or Mikrometer. German Wikipedia also uses ft and calls it "Einheitenzeichen".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll switch to the Intl.NumberFormat in the future and use the user's locale to format the units. So I think we can use ft for now

src/ui/locales/de.js Outdated Show resolved Hide resolved
src/ui/locales/de.js Outdated Show resolved Hide resolved
src/ui/locales/de.js Outdated Show resolved Hide resolved
src/ui/locales/de.js Outdated Show resolved Hide resolved
@stepankuzmin stepankuzmin changed the base branch from main to l10n-ui April 12, 2022 10:18
stepankuzmin and others added 2 commits April 12, 2022 15:02
Co-authored-by: melanie <32773863+melanieimfeld@users.noreply.github.com>
Co-authored-by: Sebastian Brockmeyer <937096+sebrockm@users.noreply.github.com>
Co-authored-by: Konstantin Käfer <mail@kkaefer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants