Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization for UI strings in Farsi #11697

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Add localization for UI strings in Farsi #11697

merged 3 commits into from
Apr 12, 2022

Conversation

stepankuzmin
Copy link
Contributor

Hey 馃憢

This PR adds translations for UI strings we use in GL JS into Farsi. We translated the UI strings automatically using the Google Translate API, and we need to verify that the translation is correct.

To help us verify the translations, you can open the Files changed tab on this page and compare the translations with the original file src/ui/default_locale.js.

If the translation looks good, you can approve it using the Review changes button in the Files changed tab and selecting the Approve radio button when submitting the review.

To improve the machine translation, you can click the plus sign next to the line you want to enhance and select the suggestion button on the toolbar.

After making the suggestions, you can mark the review as finished using the Review changes button and selecting the Request changes radio button.

Thanks for helping 馃檶

@stepankuzmin stepankuzmin added the skip changelog Used for PRs that do not need a changelog entry label Apr 11, 2022
@stepankuzmin stepankuzmin changed the base branch from main to l10n-ui April 12, 2022 10:18
Copy link

@omidmaldar omidmaldar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested some changes hoping the translations sound more native.
P.S: @moham-p please have a look if you have time. These are Farsi translations for default locales

src/ui/locales/fa.js Outdated Show resolved Hide resolved
src/ui/locales/fa.js Outdated Show resolved Hide resolved
src/ui/locales/fa.js Outdated Show resolved Hide resolved
src/ui/locales/fa.js Outdated Show resolved Hide resolved
src/ui/locales/fa.js Outdated Show resolved Hide resolved
src/ui/locales/fa.js Outdated Show resolved Hide resolved
src/ui/locales/fa.js Outdated Show resolved Hide resolved
Co-authored-by: Omid <9104489+omidmaldar@users.noreply.github.com>
Copy link

@omidmaldar omidmaldar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this as my comments are addressed. Thanks. 馃憤馃徏

@stepankuzmin stepankuzmin merged commit 0cc2579 into l10n-ui Apr 12, 2022
@stepankuzmin stepankuzmin deleted the l10n-fa branch April 12, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants