-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tile cover during globe-to-Mercator transition #12137
Conversation
7e1350a
to
abcb5c5
Compare
is there a test that validating the fix? |
@akoylasar Yes, the test here validates the fix. Previously this test was ignored since tiles were missing at the bottom (see #11988). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested a bunch with the AABB visualizer tool and fixes the issue and adds the render test! Nice work @SnailBones! As mentioned, I noticed a pole coverage issue near poles; however, may not be related to the fix in this PR, but maybe should confirm if it could be fixed here? Otherwise, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good @SnailBones !
Closes https://github.com/mapbox/gl-js-team/issues/443
Follow up to #11988 and #12075.
Solves several issues with #11988, most critically an issue in
mercatorTileCornersInCameraSpace
where camera position in Mercator now multiplied bymercatorScale
, now correctly multiplied bynumTiles
.I've verified that this function is working as intended with the AABB visualization introduced in #12131
@mapbox/map-design-team
@mapbox/static-apis
if this PR includes style spec API or visual changes@mapbox/gl-native
if this PR includes shader changes or needs a native portmapbox-gl-js
changelog:<changelog>Fix occasional missing tiles at bottom of screen during globe-Mercator transition</changelog>