Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashing Lambert Conformal Conic projection at South pole #12172

Merged
merged 3 commits into from Aug 29, 2022
Merged

Fix crashing Lambert Conformal Conic projection at South pole #12172

merged 3 commits into from Aug 29, 2022

Conversation

SnailBones
Copy link
Contributor

@SnailBones SnailBones commented Aug 17, 2022 •
edited

Fixes #12153

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fix map crashing on conformal projections at the south pole</changelog>

@SnailBones SnailBones requested a review from ansis August 17, 2022 21:53
@SnailBones SnailBones changed the title Fix broken Lambert Conformal Conic projection at South pole Fix crashing Lambert Conformal Conic projection at South pole Aug 17, 2022
ansis
ansis approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@ansis ansis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@SnailBones SnailBones merged commit 91be2e2 into main Aug 29, 2022
@SnailBones SnailBones deleted the aidan/fix-south-pole-conformal branch August 29, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansis ansis ansis approved these changes

Assignees
No one assigned
Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conformal south polar projection crashes with failed to invert matrix
2 participants
@SnailBones @ansis