Allow pitch override in camera apis #12367

karimnaaji · 2022-11-08T23:50:12Z

Add pitch override in cameraForBounds, fitBounds and fitScreenCoordiantes camera APIs
Update relevant documentation associated with these APIs

Launch Checklist

briefly describe the changes in this PR
write tests for all new functionality
document any changes to public APIs
manually test the debug page
apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Allow for pitch override in cameraForBounds, fitBounds and fitScreenCoordiantes camera APIs</changelog>

src/ui/camera.js

avpeery · 2022-11-11T00:52:32Z

LGTM - thanks for updating the debug (tested it out!) and fixing the documentation!

karimnaaji requested a review from avpeery November 8, 2022 23:50

karimnaaji requested a review from a team as a code owner November 8, 2022 23:50

karimnaaji added 3 commits November 8, 2022 15:52

Expose pitch on camera fit APIs

81ef4d6

Add unit tests

95c48f9

Revert unnecessary change

da175ab

karimnaaji force-pushed the karim/expose-pitch-camera-apis branch from 234f750 to da175ab Compare November 8, 2022 23:52

karimnaaji added the api 📝 label Nov 8, 2022

avpeery reviewed Nov 10, 2022

View reviewed changes

src/ui/camera.js Outdated Show resolved Hide resolved

Apply review feedback

8ae653b

avpeery approved these changes Nov 11, 2022

View reviewed changes

karimnaaji merged commit ced4597 into main Nov 11, 2022

karimnaaji deleted the karim/expose-pitch-camera-apis branch November 11, 2022 01:32