Fix incorrect transition flag of properties #12372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
reviewed
Nov 10, 2022
|
Good point, looks like it's not supported there either Screen.Recording.2022-11-10.at.13.31.51.mov |
endanke
force-pushed
the
endanke/remove-image-transition-spec
branch
from
a8563f9
to
61b861f
Compare
endanke
changed the title
endanke
changed the title
mourner
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the specification is incorrect as we don't actually support transitioning of properties with image types.
There's no implementation for image transitioning and currently it just works like as a hard switch when another style is loaded with different image content, as illustrated below:
Screen.Recording.2022-11-10.at.13.21.26.mov
Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes@mapbox/gl-nativeif this PR includes shader changes or needs a native portmapbox-gl-jschangelog:<changelog>Fix incorrect transition flag in *-pattern and line-dasharray properties</changelog>