Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "undefined is not an object" in coalesceChanges #12497

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

nick-romano
Copy link
Contributor

This PR fixes #11784, by implementing the change suggested by @mourner. A/B tested against published npm package and local build. Bug did not occur in local build with these changes.

Launch Checklist

  • briefly describe the changes in this PR (above)
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs (none)
  • post benchmark scores
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fixes "undefined is not an object" in coalesceChanges</changelog>

@nick-romano nick-romano requested a review from a team as a code owner January 2, 2023 19:30
@CLAassistant
Copy link

CLAassistant commented Jan 2, 2023

CLA assistant check
All committers have signed the CLA.

@mourner mourner merged commit 476ba51 into mapbox:main Jan 10, 2023
nick-romano added a commit to nick-romano/mapbox-gl-js that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"undefined is not an object" in coalesceChanges
3 participants