New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Flow to v0.188.0 #12588

Merged

stepankuzmin merged 72 commits into main from flow-0.155.1

Apr 3, 2023

Contributor

davojta commented Feb 24, 2023 •

edited by stepankuzmin

Part of #12194

The main changes in this PR are:

Use interfaces as supertypes of objects and classes since flow prevents objects from being a supertype of a class.
Switch to the arrow method properties to avoid Flow restrictions on method unbinding. See also Switch to @javascript-obfuscator/escodegen unassert-js/rollup-plugin-unassert#10
Enable constrain_writes inference mode
Use local type inference where needed
Remove the * (existential) type where needed

Launch Checklist

briefly describe the changes in this PR
manually test the debug page
apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog></changelog>

github-advanced-security bot found potential problems

View reviewed changes

src/util/mapbox.js Fixed Show fixed Hide fixed

src/util/mapbox.js Fixed Show fixed Hide fixed

stepankuzmin changed the title ~~draft - Flow 0.155.1~~ Upgrade Flow to v0.177.0

stepankuzmin added the skip changelog label

davojta commented

View reviewed changes

src/style/style_layer/circle_style_layer.js Outdated Show resolved Hide resolved

davojta commented

View reviewed changes

src/style/style_layer/fill_extrusion_style_layer.js Outdated Show resolved Hide resolved

davojta commented

View reviewed changes

src/style/style_layer/fill_style_layer.js Outdated Show resolved Hide resolved

davojta commented

View reviewed changes

src/style/style_layer/heatmap_style_layer.js Outdated Show resolved Hide resolved

davojta commented

View reviewed changes

src/style/style_layer/line_style_layer.js Outdated Show resolved Hide resolved

davojta changed the title ~~Upgrade Flow to v0.177.0~~ Upgrade Flow to v0.184.0

github-advanced-security bot found potential problems

View reviewed changes

src/util/config.js Fixed Show fixed Hide fixed

src/util/config.js Fixed Show fixed Hide fixed

stepankuzmin changed the title ~~Upgrade Flow to v0.184.0~~ Upgrade Flow to v0.188.0

stepankuzmin reviewed

View reviewed changes

src/util/config.js Show resolved Hide resolved

stepankuzmin marked this pull request as ready for review

February 27, 2023 15:33

stepankuzmin requested a review from a team as a code owner

February 27, 2023 15:33

stepankuzmin force-pushed the flow-0.155.1 branch 2 times, most recently from 3b3884d to 0d683be Compare

March 6, 2023 15:46

Contributor

stepankuzmin commented Mar 13, 2023

Unfortunately, there is no way of suppressing the method-unbinding error for the project since Flow supports only inline comments error suppression https://flow.org/en/docs/errors/

stepankuzmin and others added 13 commits

March 31, 2023 14:57


          Fix class-object-subtyping

38f668e


          More fixes


          flow fix

e1809e3


          Fix flow

d91278f


          Update vectortile_to_geojson

fec0da1


          Fix eslint indentation

4adc958


          Fix method-unbinding

46cd568


          Update flow to v0.155.1


          Fix method-unbinding

e519826


          flow 0.153.0 eslint fix (#12586)

d676094

* fix eslint problems for source_cache.js

* fix eslint problems for style/style.js

* fix eslint problems for util/actor.js

* fix eslint problems for ui/map.js

* fix eslint problems for ui/marker.js

* fix eslint problems for ui/camera.js

* fix eslint problems for terrain/terrain.js

* fix eslint problems for ui/handler_manager.js


          Fix method-unbinding in evaluation_parameters.js

a554168


          Fix method-unbinding in uniform_binding.js

4e3506a


          Fix method-unbinding in lng_lat_bounds.js

5c2cbce

davojta and others added 22 commits

March 31, 2023 14:57


          fix formatting for ui/map.js

31edc5b


          Upgrade Flow to v0.184.0

2647e71


          fix formatting for ui/handler_manager.js

67f61a7


          fix formatting for rest of ui folder

18ae169

* hash.js
* marker.js
* popup.js
* scroll_zoom.js


          fix formatting for terrain.js

2eec22b


          fix formatting for style.js

665ef89


          fix formatting for custom_style_layer.js

c84eef7


          fix formatting for source_cache.js

6a10d00


          fix formatting for grid_index.js

a63ed32


          fix formatting for expression/index.js

cd99939


          Enable constrain_writes inference mode

be873dd

See https://flow.org/en/docs/config/options/#toc-inference-mode-classic-constrain-writes


          Upgrade Flow to v0.185.0

5070edd


          Upgrade Flow to v0.186.0

4f8f733


          Upgrade Flow to v0.187.0

234501c


          Upgrade Flow to v0.188.0

ce6bece


          Fix src/geo/transform.js

1f789b3


          Cleanup

cb52c71


          Cleanup formatting

17eef44


          Fix layoutType in program_configuration.js

a055f35


          Fix ProgramConfiguration constructor

64bdec6


          Fix EVENTS_URL sanitization

3a38962


          Cleanup

3a85820

stepankuzmin force-pushed the flow-0.155.1 branch from 0d683be to 3a85820 Compare

March 31, 2023 12:15


          Revert flow method-unbinding fixes and supress errors

4ca5ac4

mourner approved these changes

View reviewed changes

Member

mourner left a comment

The PR looks great in general, and while the $FlowFixMe[method-unbinding] thing is unfortunate, the alternative is worse (arrow methods are less widely supported and have bundle size overhead), and I think we should land the PR to move forward with typing coverage — perhaps we can address those later.

src/render/painter.js Outdated Show resolved Hide resolved

src/data/load_geometry.js Show resolved Hide resolved


          Fix painter.js

c6302c3

stepankuzmin merged commit 2ed446a into main

stepankuzmin deleted the flow-0.155.1 branch

April 3, 2023 14:25

This was referenced Apr 13, 2023

Vue3+Vite does not work. Error occurred while parsing the WebWorker bundle. #12656

Closed

Forbid class fields to fix transpilation errors with Vite/ESBuild #12658

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment