Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrow character codes on the verticalizedCharacterMap #12608

Merged

Conversation

kkokkojeong
Copy link
Contributor

@kkokkojeong kkokkojeong commented Mar 8, 2023

Launch Checklist

I know that CJK fonts are complex to render. During testing, I found that the arrow special character and CJK font representation were ugly.
This PR describes that is to add arrow special character to the verticalizedCharacterMap object.

I had test named Display line that crosses 180th meridian

(Ps. I'm awesome about the great mapbox library 馃憤 )

before after
image image
  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Add arrow characters to the map of verticalized character</changelog>

@kkokkojeong kkokkojeong requested a review from a team as a code owner March 8, 2023 06:00
@CLAassistant
Copy link

CLAassistant commented Mar 8, 2023

CLA assistant check
All committers have signed the CLA.

@kkokkojeong kkokkojeong force-pushed the add-arrow-verticalizedCharacterMap branch from 3500a32 to 410d488 Compare March 8, 2023 06:15
Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @kkokkojeong 馃憤

@stepankuzmin stepankuzmin merged commit af48548 into mapbox:main Mar 8, 2023
@kkokkojeong kkokkojeong deleted the add-arrow-verticalizedCharacterMap branch March 8, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants